Re: [PATCH] staging: comedi: cleanup all the comedi_driver 'detach'functions

[Ian Abbott]

On 2012-05-18 01:11, H Hartley Sweeten wrote:
> 2. Remove all the printk noise in the detach functions
>
> All of the printk output is really just noise. The user did a rmmod to
> unload the driver, we really don't need to tell them about it.

I disagree.  It's not that unusual for drivers to report device removal. 
 (It's not necessarily due to an rmmod either, not that that really 
matters.)

> Also, some of the messages are output using:
>
>          dev_dbg(dev->hw_dev, ...
> or
>          dev_info(dev->hw_dev, ...
>
> Unfortunately the hw_dev value is only used by drivers that are doing
> DMA. For most drivers this variable is going to be NULL so the output
> is not going to work as expected.

Agreed, those are bugs introduced by someone else's "cleanup"!

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/