Re: [tip:sched/core] sched: Set TAINT_UNSAFE_SMP aftersleep-in-atomic bug

From: Peter Zijlstra
Date: Fri May 18 2012 - 07:03:02 EST


On Fri, 2012-05-18 at 03:48 -0700, tip-bot for Konstantin Khlebnikov
wrote:
> Acked-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

This is the patch I objected to..

> +++ b/kernel/sched/core.c
> @@ -3138,6 +3138,7 @@ static noinline void __schedule_bug(struct task_struct *prev)
> if (irqs_disabled())
> print_irqtrace_events(prev);
> dump_stack();
> + add_taint(TAINT_UNSAFE_SMP);
> }

This should very much be TAINT_WARN.. it has nothing what so ever to do
with SMP.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/