Re: [PATCH RFC tip/core/rcu 2/2] rcu: Fix broken strings in RCU'ssource code.

From: Paul E. McKenney
Date: Fri May 18 2012 - 08:33:35 EST


On Fri, May 18, 2012 at 08:33:08AM +0200, Ingo Molnar wrote:
>
> * Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
>
> > On Thu, 2012-05-17 at 15:12 -0700, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>
> > >
> > > Although the C language allows you to break strings across lines, doing
> > > this makes it hard for people to find the Linux kernel code corresponding
> > > to a given console message. This commit therefore fixes broken strings
> > > throughout RCU's source code.
> >
> > While I'm not a strict 80 chars zealot, I do find exceedingly
> > long lines utterly annoying, editors either wrap them in the
> > most hideous way or you don't see them.
>
> Well, but if it's exceedingly long in the editor then it's
> probably exceedingly long in the syslog as well and need fixing,
> right?
>
> Or it's printed inside some exceedingly deep nested block of
> code, which too could use improvement, right?

The longest source-code line produced by this patch is 104 characters.

I am hoping that this is not considered excessively long!

Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/