Re: [PATCH 08/10] Use __kernel_ulong_t in struct msqid64_ds

From: H. Peter Anvin
Date: Fri May 18 2012 - 17:41:35 EST


On 05/18/2012 02:31 PM, Arnd Bergmann wrote:
>
> However, in the kernel we *always* copy the fields one by one for compat
> mode, even for the architectures that have identical layout between 32 and
> 64 bit, and at least one libc implementation that I've seen (IIRC uClibc)
> hardcodes the data structure to be the same as x86, with the padding
> after the 'long', for all architectures. When I introduced the asm-generic
> version of this, we had a discussion about whether we should try to use
> the version with the "correct" padding but in the end decided to just use
> the x86 version because that is what most big-endian architectures do
> anyway.
>

Ouch. Fail. asm-generic should be about what is the right thing going
forward.

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/