Re: [PATCH] staging: comedi: cleanup all the comedi_driver 'detach'functions

[Ian Abbott]

On 19/05/12 01:32, Greg KH wrote:
> On Thu, May 17, 2012 at 05:11:14PM -0700, H Hartley Sweeten wrote:
> > All of the printk output is really just noise. The user did a rmmod to
> > unload the driver, we really don't need to tell them about it.
> >
> > Also, some of the messages are output using:
> >
> > 	dev_dbg(dev->hw_dev, ...
> > or
> > 	dev_info(dev->hw_dev, ...
> >
> > Unfortunately the hw_dev value is only used by drivers that are doing
> > DMA. For most drivers this variable is going to be NULL so the output
> > is not going to work as expected.

They don't crash and still produce kernel logs, but replaces the device 
class and device name in the log entry with "(NULL device *)" or 
something like that.

> Sorry about that, I probably caused a lot of that.  As no one ever
> complained, odds are no one is using those drivers :)

Most of them seem to have from Ravishankar Karkala Mallikarjunayya.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/