Re: [ 31/54] kmemleak: Fix the kmemleak tracking of the percpuareas with !SMP

[Catalin Marinas]

On Sat, May 19, 2012 at 03:46:52PM +0100, Greg KH wrote:
> On Sat, May 19, 2012 at 03:27:33PM +0200, Christoph Biedl wrote:
> > Greg KH wrote...
> > 
> > > 3.0-stable review patch.  If anyone has any objections, please let me know.
> > 
> > > From: Catalin Marinas <catalin.marinas@xxxxxxx>
> > > 
> > > commit 100d13c3b5b9410f604b86f5e0a34da64b8cf659 upstream.
> > 
> > > +	/* kmemleak tracks the percpu allocations separately */
> > > +	kmemleak_free(fc);
> > 
> > That one causes:
> > 
> >     mm/percpu.c: In function âsetup_per_cpu_areasâ:
> >     mm/percpu.c:1877: error: implicit declaration of function âkmemleak_freeâ
> >     make[1]: *** [mm/percpu.o] Error 1
> >     make: *** [mm] Error 2
> 
> Odd, it doesn't cause that problem here for me, what ARCH are you
> building for?  I'm on x86-64.

This patch propagated to far in the past. Support for per-cpu areas in
kmemleak was added with commit f528f0b8e5 (kmemleak: Handle percpu
memory allocation) in 3.3-rc1. That patch introduced the correct
#include for kmemleak.h.

Commit 100d13c should only be applied to stable 3.3 and not earlier.

Thanks.

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/