Re: [PATCH v2] gpio/generic: initialize basic_mmio_gpio shadowvariables properly
From: Grant Likely
Date: Sun May 20 2012 - 02:00:20 EST
On Sat, May 19, 2012 at 8:10 PM, Shawn Guo <shawn.guo@xxxxxxxxxxxxx> wrote:
> On Sat, May 19, 2012 at 12:12:42PM -0600, Grant Likely wrote:
>> On Sat, 19 May 2012 16:55:51 +0800, Shawn Guo <shawn.guo@xxxxxxxxxx> wrote:
>> > It fixes the issue in gpio-generic that commit fb14921 (gpio/mxc: add
>> > missing initialization of basic_mmio_gpio shadow variables) manged to
>> > fix in gpio-mxc driver, so that other platform specific drivers do not
>> > suffer from the same problem over and over again.
>> >
>> > Changes since v1:
>> > * Turn the last parameter "bool big_endian" into "unsigned long flags"
>> > and give those really quirky hardwares a chance to tell that reg_set
>> > and reg_dir are unreadable.
>> >
>> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
>>
>> Applied, thanks.
>>
> Grant,
>
> Can you please pick up the RESEND version of the patch, which had
> bgpio_pdev_probe adapt bgpio_init parameter change too?
I did even though I replied to the original.. You can check my
gpio/next branch to be sure.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/