Re: [PATCH 1/3] USB: qmi_wwan: Make forced int 4 whitelist generic

[BjÃrn Mork]

Andrew Bird <ajb@xxxxxxxxxxxxxxxxxxx> writes:

> Change the forced interface 4 whitelist to use the generic shared
> binder instead of the Gobi specific one. Certain ZTE devices
> (K3520-Z & K3765-Z) don't work with the Gobi version, but function
> quite happily with the generic. This has been tested with the following
> devices:
> K3520-Z
> K3565-Z
> K3765-Z
> K4505-Z
> It hasn't been tested with the ZTE MF820D, which is the only other
> device that uses this whitelist at present. Although Bjorn doesn't
> expect any problems, any testing with that device would be appreciated.
>
> Signed-off-by: Andrew Bird <ajb@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/net/usb/qmi_wwan.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index d316503b..62a1a43 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -357,9 +357,9 @@ static const struct driver_info	qmi_wwan_gobi = {
>  
>  /* ZTE suck at making USB descriptors */
>  static const struct driver_info	qmi_wwan_force_int4 = {
> -	.description	= "Qualcomm Gobi wwan/QMI device",
> +	.description	= "Qualcomm WWAN/QMI device",
>  	.flags		= FLAG_WWAN,
> -	.bind		= qmi_wwan_bind_gobi,
> +	.bind		= qmi_wwan_bind_shared,
>  	.unbind		= qmi_wwan_unbind_shared,
>  	.manage_power	= qmi_wwan_manage_power,
>  	.data		= BIT(4), /* interface whitelist bitmap */

Acked-by: BjÃrn Mork <bjorn@xxxxxxx>

This fixes a logical error in the code.  Minidriver constructs with an
interface whitelist should not use qmi_wwan_bind_gobi.  It was made to
prevent binding to the serial interfaces on Gobi devices, and serves no
useful purpose when used with a whitelist.  The change is a no-op for
the ZTE MF820D, but is important for new devices.

Thanks for fixing this.


BjÃr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/