Re: Clock register in early init

[Ben Dooks]

On 21/05/12 09:46, Peter De Schrijver wrote:
> > On OMAP I think the only "gotcha" is setting up the timer.  One
> > solution is to open code the register reads and the rate calculation
> > in the timer code.  That is ugly... but it works.
> >
> > > Which advantages do you see in dynamically allocating all this?
> >
> > There are many but I'll name a couple.  The most significant point is
> > that we can avoid exposing the definition of struct clk if we
> > dynamically allocate stuff.  One can use struct clk_hw_init to
> > statically initialize data, or instead rely on direct calls to
> > clk_register with a bunch of parameters.
>
> Which means if you make a mistake in specifying parents for example, it will
> only fail at runtime, possibly before any console is active. With static
> initialization, this will fail at compiletime. Much easier to debug.
>
> > Another point is that copying the data at registration-time makes
> > __initdata possible.  I haven't done the math yet to see if this
> > really makes a difference.  However if we start doing single zImage's
> > with multiple different ARM SoCs then this could recover some pages.
>
> On the other hand most clock structures are small, so there will be internal
> fragmentation. Also the arrays of parent clock pointers can be shared between
> different clocks. We have about 70 muxes in Tegra30 and 12 different parent
> arrays.

We had at-least that on the older Samsung parts and they where still
growing. I would suggest that in a multi-kernel image situation the
more data that can be discarded after init-time the better.

Also, __initdata gets gathered into one place so there's no possibility
of page fragmentation there. If you mean fragmentation of the memory
map, then allocate the size of all the clocks you know of at init time
in one go.

It would possible even be useful to have construction code that took
some brief details of the clocks and constructed the list/tree of clocks
at start time.

--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/