Re: [PATCH 5/5] netdev/phy: Add driver for Cortina cs4321 quad 10GPHY.

From: David Daney
Date: Tue May 22 2012 - 15:26:45 EST


On 05/22/2012 11:50 AM, Ben Hutchings wrote:
On Tue, May 22, 2012 at 10:59:52AM -0700, David Daney wrote:
[...]
--- /dev/null
+++ b/drivers/net/phy/cs4321-ucode.h
@@ -0,0 +1,4378 @@
+/*
+ * Copyright (C) 2011 by Cortina Systems, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
[...]

So where's the real source code for it?

I wish I knew. The vendor released the array of random numbers as GPL to us. :-(


If you won't (or can't) provide source code for the microcode then it
should instead be submitted to linux-firmware with a binary
redistribution licence, and the driver should load it with
request_firmware().

I will attempt to do that.

The .c file contains plenty of other pseudo-random numbers, but those cannot really be considered 'firmware'

David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/