Re: [PATCH] power: add knob for printing device resume times

[Greg KH]

On Tue, May 22, 2012 at 12:16:45PM -0700, Sameer Nanda wrote:
> Added a new knob called /sys/powe/pm_print_times. Setting it to 1
> enables printing of time taken by devices to suspend and resume.
> Setting it to 0 disables this printing (unless overridden by
> initcall_debug kernel command line option).
> 
> Signed-off-by: Sameer Nanda <snanda@xxxxxxxxxxxx>
> cc: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> cc: Rafael J. Wysocki <rjw@xxxxxxx>
> cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
> ---
>  drivers/base/power/main.c  |    4 ++--
>  drivers/base/power/power.h |   11 +++++++++++
>  kernel/power/main.c        |   34 ++++++++++++++++++++++++++++++++++
>  3 files changed, 47 insertions(+), 2 deletions(-)

Not getting into if this patch is correct or not, it's obviously wrong
in that you are adding a new sysfs file to the system, yet you did not
add a Documentation/ABI/ file documenting exactly what this file does
and how to use it.

Please redo it with that added, and fix the obvious typo in the
changelog body as well :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/