Re: [PATCH] usb-hid-core: Set intfdata to NULL if probe fails

From: Jiri Kosina
Date: Tue May 22 2012 - 18:00:42 EST


On Tue, 22 May 2012, Hans de Goede wrote:

> Well then lets work towards making it guaranteed, since I still believe
> the following holds true:
> 1) drvdata is for a driver to store a pointer to driver specific data
> 2) If no driver is bound, there is no driver specific data associated with
> the device
> 3) Thus logically drvdata should be NULL if no driver is bound.
>
> I'll do a patch for the USB-core to ensure that intfdata gets set to NULL
> on probe failure.

Hans,

I believe this is a good thing per se, but shouldn't this rather be done
in driver core, to guarantee that this hold across all buses?

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/