Re: [PATCH 2/3] regulator: MAX77686: Add Maxim 77686 regulator driver

[jonghwa3 . lee]

Hi, Mark,
On 2012ë 05ì 21ì 18:55, Mark Brown wrote:

> On Mon, May 21, 2012 at 04:33:15PM +0900, jonghwa3.lee@xxxxxxxxxxx wrote:
>> On 2012ë 05ì 21ì 00:56, Mark Brown wrote:
>>> On Fri, May 18, 2012 at 06:32:18PM +0900, Jonghwa Lee wrote:
> 
>>>> +	}, {
>>>> +		.name	= "EN32KHz PMIC",
>>>> +		.id	= MAX77686_P32KH,
>>>> +		.ops	= &max77686_fixedvolt_ops,
>>>> +		.type	= REGULATOR_VOLTAGE,
>>>> +		.owner	= THIS_MODULE,
>>>> +	},
> 
>>> These should be managed via the clock API now we have one.
> 
>> I already updated all your comments except only this one. Could you
>> explain more details?
> 
> We now have a generic clock framework in drivers/clk so we should be
> using that to provide drivers for clocks rather than putting them into
> the regulator API which was always a bodge.


I tried to change API to generic version but it got problem because of
overlapping. As you know almost of boards uses private clock API not
generic. So how do you think can i test it without modifying board file?
I'm afraid of changing all clock registering is too expensive.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/