Re: [RFC/PATCH] Bluetooth: prevent double l2cap_chan_destroy

From: Minho Ban
Date: Tue May 22 2012 - 21:39:33 EST


On 05/22/2012 09:23 PM, Chanyeol Park wrote:
> Hi
>
> On 2012ë 05ì 22ì 11:50, Minho Ban wrote:
>> @@ -1343,10 +1343,10 @@ static void l2cap_conn_del(struct hci_conn *hcon, int err)
>> l2cap_chan_lock(chan);
>>
>> l2cap_chan_del(chan, err);
>> + chan->ops->close(chan->data);
>>
>> l2cap_chan_unlock(chan);
>>
>> - chan->ops->close(chan->data);
>> l2cap_chan_put(chan);
>> }
> I think this patch does not make sense Because inside chan->ops->close() "chan" could be freed in the l2cap_chan_destroy().
>

I agree, thanks for pointing out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/