Re: [PATCH v3 2/2] regulator: Add support for MAX77686.

[Yadwinder Singh Brar]

Hi,

On Wed, May 23, 2012 at 7:20 AM,  <jonghwa3.lee@xxxxxxxxxxx> wrote:
> Hi, again.
> On 2012ë 05ì 22ì 14:57, yadi.brar01@xxxxxxxxx wrote:
>
>
>> +static __devinit int max77686_pmic_probe(struct platform_device *pdev)
>> +{
>
>> +
>> + Â Â for (i = 0; i < pdata->num_regulators; i++) {
>> + Â Â Â Â Â Â config.dev = max77686->dev;
>> + Â Â Â Â Â Â config.init_data = pdata->regulators[i].init_data;
>> + Â Â Â Â Â Â config.driver_data = max77686;
>> + Â Â Â Â Â Â config.regmap = iodev->regmap;
>> +
>> + Â Â Â Â Â Â rdev[i] = regulator_register(&regulators[i], &config);
>
>
> I'm sorry that i missed one. You have to register all regulators
> unconditionally. Mark brown commented about this to my former patch.
>
> 'No, you should unconditionally register all regulators the device
> physically has. ÂThis is useful for debug and simplifies the code.'
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â- from Mark Brown
>

Yes, we are registering all regulators here.
As pdata->num_regulators will be equal to ARRAY_SIZE(regulators)

Thanks,
Yadwinder.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/