Re: Bug in sysfs bin attribute?

[Vikas Chaudhary]

-----Original Message-----
From: "gregkh@xxxxxxxxxxxxxxxxxxx" <gregkh@xxxxxxxxxxxxxxxxxxx>
To: Vikas Chaudhary <vikas.chaudhary@xxxxxxxxxx>
Cc: linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, Mike Christie
<michaelc@xxxxxxxxxxx>, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Lalit Chandivade
<lalit.chandivade@xxxxxxxxxx>, Ravi Anand <ravi.anand@xxxxxxxxxx>
Subject: Re: Bug in sysfs bin attribute?

>On Tue, May 22, 2012 at 10:38:11PM -0700, Vikas Chaudhary wrote:
>>
>> We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver.
>> Here is patch for same: -
>> http://marc.info/?l=linux-scsi&m=133733192809849&w=2
>>
>>
>> In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print
>> string coming in 'char *buf'
>> from sysfs attribute it contain value we echo on sysfs attribute
>>'fw_dump'
>> plus some garbage data.
>
>Why are you not using the built-in firmware interface the kernel
>provides you?  What does it lack that you need here?

In this patch we are not trying to load firmware, Here we are trying to
collect
firmware dump in case of adapter firmware crash. The firmware dump is in
driver buffer
and we want to extract it at user space using the sysfs bin attribute.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/