Re: [PATCH] slab+slob: dup name string

[James Bottomley]

On Wed, 2012-05-23 at 16:08 +0400, Glauber Costa wrote:
> On 05/23/2012 03:46 PM, James Bottomley wrote:
> >> We can't predict how slab will be extended in the future and this affects
> >> >  anything created before g_cpucache_cpu<= EARLY.  This would introduce the
> >> >  first problem with destroying such caches and is unnecessary if a
> >> >  workaround exists.
> > These problems seem to indicate that the slab behaviour: expecting the
> > string to exist for the lifetime of the cache so there's no need to copy
> > it might be better.
> >
> > This must be the behaviour all users of kmem_cache_create() expect
> > anyway, since all enterprise distributions use slab and they're not
> > getting bugs reported in this area.
> >
> > So, why not simply patch slab to rely on the string lifetime being the
> > cache lifetime (or beyond) and therefore not having it take a copy?
> >
> You mean patch slub? slub is the one that takes a copy currently.

Yes ... a one letter typo.  

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/