Re: [PATCH V2] x86/pci: sta2x11: fix a compiler warning

[Thomas Gleixner]

On Wed, 23 May 2012, Alessandro Rubini wrote:

> swiotlb_free_coherent(), exported by lib/swiotlb.b, cannot be used in
> dma_ops, because it doesn't want the "attrs" argument.  Add a wrapper,
> like other users of the function already do.
> 
> Signed-off-by: Alessandro Rubini <rubini@xxxxxxxxx>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@xxxxxx>
> ---
> 
> [V2: same patch, message fixed (sorry, I made a mess in the editor)]
> 
> Actually, we may instead add "args" to the exported functions in
> lib/swiotlb.  This would then remove a few other similar wrappers that
> do nothing.  If it's considered useful, I can propose a patch for that.

Yes please. Do nothing wrappers are harmful espcially if they get
common.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/