Re: [PATCH v4] regulator: MAX77686: Add Maxim 77686 regulator driver
From: Yadwinder Singh Brar
Date: Tue May 29 2012 - 00:21:34 EST
On Tue, May 29, 2012 at 7:40 AM, <jonghwa3.lee@xxxxxxxxxxx> wrote:
Hi Jonghwa,
>>> +
>>> + for (i = 0; i < MAX77686_REGULATORS; i++) {
>>> + if (pdata)
>>> + init_data[pdata->regulators[i].id] =
>>> + pdata->regulators[i].initdata;
>>
>> I think we can directly use pdata->regulators[i].initdata instead of
>> init_data[i].
>> In case if pdata is not their we can use same instance of
>> init_data(default) for all regulators.
>>
>
>
> This if for some situation that pdata's initdata doensn't line up. When
Ok, but I think this not right place for sorting (sorting is not taking
place.) You have to sort it before entering in loop for registering
regulators.
> user sets only initdata considered it being used, there may be
> regulators not having initdata, also its order is not clear. So for
Ok, I think this is a bug in present driver also, because
without checking pdata->num_regulators, you are running in
loop for (i = 0; i < MAX77686_REGULATORS; i++)
where MAX77686_REGULATORS should be equal to
pdata->num_regulators for this driver to work fine.
If we consider a case pdata->num_regulators is
equal to MAX77686_REGULATORS and initdata is
not their(i.e. NULL) than I think it will initialise
init_data[pdata->regulators[i].id to NULL, which again will be a bug.
> those state, i think just using temporary array which satisfies
> regulator's id order is fine while it can't use pdata's initdata directly.
>
If I am not wrong, I think we can also sort pdata's initdata also using
kernel's sort api and use one instance of (default)initdata for
all unused or uninitialized regulators in platform file.
>>> +
>>> + config.init_data = init_data[i];
>>> + rdev[i] = regulator_register(®ulators[i], &config);
>>> +
>>
Regards,
Yadwinder.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/