Re: [PATCH] regulator: gpio-regulator: Set the smallest voltage/current in the specified range

[Yi Zhang]

Mark Brown <broonie <at> opensource.wolfsonmicro.com> writes:

> 
> On Thu, Mar 22, 2012 at 02:08:04PM +0800, Axel Lin wrote:
> > Do not assume the gpio regulator states map is sorted in any order.
> > This patch ensures we always set the smallest voltage/current that falls 
within
> > the specified range.
> 
> Applied, thanks.
> 

 	struct gpio_regulator_data *data = rdev_get_drvdata(dev);
-	int ptr, target, state;
+	int ptr, target, state, best_val = INT_MAX;

-	target = -1;
 	for (ptr = 0; ptr < data->nr_states; ptr++)
-		if (data->states[ptr].value >= min &&
+		if (data->states[ptr].value < best_val &&
+		    data->states[ptr].value >= min &&
 		    data->states[ptr].value <= max)
 			target = data->states[ptr].gpios;

-	if (target < 0)
+	if (best_val == INT_MAX)

Here seems something wrong, for best_val is always INT_MAX. From the discussion 
above, maybe best_val is should be reassigned in the for loop.
It may be like as the following:

-       for (ptr = 0; ptr < data->nr_states; ptr++)
+       for (ptr = 0; ptr < data->nr_states; ptr++) {
                if (data->states[ptr].value < best_val &&
                    data->states[ptr].value >= min &&
-                   data->states[ptr].value <= max)
+                   data->states[ptr].value <= max) {
                        target = data->states[ptr].gpios;
+                       best_val = target;
+       }

What do you think? thanks;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/