Re: WARNING: at mm/page-writeback.c:1990__set_page_dirty_nobuffers+0x13a/0x170()

[Hugh Dickins]

On Fri, 1 Jun 2012, KOSAKI Motohiro wrote:
> >   	mlock_migrate_page(newpage, page);
> > --- 3.4.0+/mm/page-writeback.c	2012-05-29 08:09:58.304806782 -0700
> > +++ linux/mm/page-writeback.c	2012-06-01 00:23:43.984116973 -0700
> > @@ -1987,7 +1987,10 @@ int __set_page_dirty_nobuffers(struct pa
> >   		mapping2 = page_mapping(page);
> >   		if (mapping2) { /* Race with truncate? */
> >   			BUG_ON(mapping2 != mapping);
> > -			WARN_ON_ONCE(!PagePrivate(page)&&
> > !PageUptodate(page));
> > +			if (WARN_ON(!PagePrivate(page)&&
> > !PageUptodate(page)))
> > +				print_symbol(KERN_WARNING
> > +				    "mapping->a_ops->writepage: %s\n",
> > +				    (unsigned
> > long)mapping->a_ops->writepage);
> 
> type mismatch?

I don't think so: I just copied from print_bad_pte().
Probably you're reading "printk" where it's "print_symbol"?

> I guess you want %pf or %pF.

I expect there is new-fangled %pMagic that can do it too, yes.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/