Re: [PATCH 05/11] mtip32xx: Set block queue boundary variables

[Jeff Moyer]

Jens Axboe <axboe@xxxxxxxxx> writes:

>> Jens, I actually think changing nr_requests makes sense;  the only
>> question in my mind is where to do it.  (There's no point in artificially
>> limiting the device by default.)  IIRC, your general rule was to set this
>> value to 2x the device's queue depth.  So, given that this driver
>> doesn't use the blk-tag interfaces, what do you think would be the
>> cleanest way to bump nr_requests in this (and the more general) case?
>
> But it doesn't matter for this case, the driver isn't consuming request
> structures, hence the value set doesn't make any difference. So the only
> limiter of queue depth is the driver itself.

Good point.  Nevermind.  ;-)

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/