Re: [PATCH] add new NRP power meter USB device driver

[Oliver Neukum]

Am Donnerstag, 31. Mai 2012, 16:32:55 schrieb Greg KH:
> On Thu, May 31, 2012 at 04:22:31PM +0200, Oliver Neukum wrote:

> > It seems to specialised for this kind of IO. SPI over USB is closer to a generic
> > thing rather like sg or even a bus rather than an IIO device. Kernel space drivers
> > that use SPI might belong into IIO. The infrastructure itself not so much.
> 
> Wait, are you talking about the SPI we already support in the kernel?

Damn, one should watch one's spelling. SPI != SCPI
In the kernel we have SPI. This proposed driver is for SCPI.
The only relation they have is phonetic.

> Or something else?  This driver really looks like it wants to send to
> userspace "measurements" of something, which IIO is for.

As far as I can tell, it works by messages over a bus, rather like SCSI.
> 
> Anyway, as-is, this isn't acceptable, I'm sure we can all agree on that
> :)

Well, apart from the only ioctl I've seen far worse drivers.
The issue is not the driver as such, but whether and it what form it should exist.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/