Re: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table.
From: Ohad Ben-Cohen
Date: Sun Jun 03 2012 - 09:42:28 EST
On Tue, May 22, 2012 at 4:26 PM, <sjur.brandeland@xxxxxxxxxxxxxx> wrote:
> From: Sjur Brændeland <sjur.brandeland@xxxxxxxxxxxxxx>
>
> Prepare for pluggable firmware handling by calling firmware
> sanity check from function find_rsc_table.
Can we keep the present location of rproc_fw_sanity_check(), and later
just invoke the relevant ops handler instead?
> @@ -1041,8 +1041,10 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw)
>
> /* look for the resource table */
> table = rproc_find_rsc_table(rproc, fw, &tablesz);
> - if (!table)
> + if (!table) {
> + ret = -EINVAL;
This looks like an unrelated error-path fix which we might want to
merge regardless of this work.
Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/