Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170()

[Linus Torvalds]

On Sun, Jun 3, 2012 at 3:17 PM, Hugh Dickins <hughd@xxxxxxxxxx> wrote:
>
> But another strike against that commit: I tried fixing it up to use
> start_page instead of page at the end, with the worrying but safer
> locking I suggested at first, with a count of how many times it went
> there, and how many times it succeeded.

You can't use start_page anyway, it might not be a valid page. There's
a reson it does that "pfn_valid_within()", methinks.

Anyway, my current plan is to apply your "mm: fix warning in
__set_page_dirty_nobuffers" patch - even if it's just a harmless
WARN_ON_ONCE(), and revert 5ceb9ce6fe94. Sounds like Dave hit normally
hit his problem much before two hours, and it must be even longer now.

Ack on that plan?

        Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/