Re: [RFC 3/6] remoteproc: Move fw sanity check to find_rsc_table.

[Ohad Ben-Cohen]

On Mon, Jun 4, 2012 at 12:56 PM, Sjur BRENDELAND
<sjur.brandeland@xxxxxxxxxxxxxx> wrote:
> The sanity_check() is working on the ELF structures. And all ELF
> processing needs to be moved to a separate file. So if you want
> to keep the call to sanity_check() here, I need to make the
> sanity_check() function a separate handler. That could make sense,
> but will also bloat the struct rproc_fw_ops with one more function
> pointer.

I think it's OK.

Adding another handler is cheap, and if by doing so the code becomes
even slightly easier to read or maintain, it's probably worth it.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/