RE: [PATCH 1/1] net/hyperv: Use wait_event on outstanding sendsduring device removal

From: Haiyang Zhang
Date: Mon Jun 04 2012 - 12:14:23 EST




> -----Original Message-----
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Monday, June 04, 2012 11:48 AM
> To: Haiyang Zhang
> Cc: netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/1] net/hyperv: Use wait_event on outstanding sends
> during device removal
>
> From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Date: Mon, 4 Jun 2012 07:35:32 -0700
>
> > + wait_event(net_device->wait_drain,
> > + atomic_read(&net_device->num_outstanding_sends) == 0);
>
> Please indent this properly. The goal is not to indent using only
> TAB characters, the goal is to line things up to the proper column
> using TAB and space characters as needed.
>
> You must make the first character on the second line be at the
> first column after the openning parenthesis on the previous line.

Will do.

Thanks,
- Haiyang

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/