Re: [PATCH 5/6] um: fully use tty_port

[Jiri Slaby]

On 06/04/2012 10:27 PM, Richard Weinberger wrote:
> +void line_cleanup(struct tty_struct *tty)
> +{
> +	struct line *line = tty->driver_data;
>  
>  	if (line->sigio) {
>  		unregister_winch(tty);
>  		line->sigio = 0;

r u sure you want to to do this asynchronously? This should be
tty_port_operations->shutdown I suppose...

>  	}
> +}

Anyway, please split the patch into 2 pieces at least:
1) introducing ->install and moving the setup there.
2) switching to tty port helpers
Otherwise it's a hard-to-review mess.

thanks,
-- 
js
suse labs


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/