Re: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting

[Jens Axboe]

On 06/04/2012 09:44 PM, Asai Thambi S P wrote:
> @@ -4062,10 +4210,20 @@ static int __init mtip_init(void)
>  	}
>  	mtip_major = error;
>  
> +	if (!dfs_parent) {
> +		dfs_parent = debugfs_create_dir("rssd", NULL);
> +		if (IS_ERR_OR_NULL(dfs_parent)) {
> +			printk(KERN_WARNING "Error creating debugfs parent\n");
> +			dfs_parent = NULL;
> +		}
> +	}
> +

Why would dfs_parent ever be non-NULL here?

Apart from that, looks fine.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/