[tip:smp/hotplug] mn10300: SMP: Remove call to ipi_call_lock()/ipi_call_unlock()

From: tip-bot for Yong Zhang
Date: Tue Jun 05 2012 - 11:46:00 EST


Commit-ID: 4cbd19fcf9d49f28766415b96eb6201bc263d817
Gitweb: http://git.kernel.org/tip/4cbd19fcf9d49f28766415b96eb6201bc263d817
Author: Yong Zhang <yong.zhang0@xxxxxxxxx>
AuthorDate: Tue, 29 May 2012 15:15:57 +0800
Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
CommitDate: Tue, 5 Jun 2012 17:27:12 +0200

mn10300: SMP: Remove call to ipi_call_lock()/ipi_call_unlock()

ipi_call_lock/unlock() lock resp. unlock call_function.lock. This lock
protects only the call_function data structure itself, but it's
completely unrelated to cpu_online_mask. The mask to which the IPIs
are sent is calculated before call_function.lock is taken in
smp_call_function_many(), so the locking around set_cpu_online() is
pointless and can be removed.

[ tglx: Massaged changelog ]

Signed-off-by: Yong Zhang <yong.zhang0@xxxxxxxxx>
Cc: ralf@xxxxxxxxxxxxxx
Cc: sshtylyov@xxxxxxxxxx
Cc: david.daney@xxxxxxxxxx
Cc: nikunj@xxxxxxxxxxxxxxxxxx
Cc: paulmck@xxxxxxxxxxxxxxxxxx
Cc: axboe@xxxxxxxxx
Cc: peterz@xxxxxxxxxxxxx
Cc: David Howells <dhowells@xxxxxxxxxx>
Cc: Koichi Yasutake <yasutake.koichi@xxxxxxxxxxxxxxxx>
Cc: linux-am33-list@xxxxxxxxxx
Link: http://lkml.kernel.org/r/1338275765-3217-3-git-send-email-yong.zhang0@xxxxxxxxx
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@xxxxxxxxxxxxxxxxxx>
Acked-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
---
arch/mn10300/kernel/smp.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/mn10300/kernel/smp.c b/arch/mn10300/kernel/smp.c
index 090d35d..e62c223 100644
--- a/arch/mn10300/kernel/smp.c
+++ b/arch/mn10300/kernel/smp.c
@@ -876,9 +876,7 @@ static void __init smp_online(void)

notify_cpu_starting(cpu);

- ipi_call_lock();
set_cpu_online(cpu, true);
- ipi_call_unlock();

local_irq_enable();
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/