Re: [PATCH] fix usb skeleton driver

From: Oliver Neukum
Date: Wed Jun 06 2012 - 14:49:59 EST


Am Mittwoch, 6. Juni 2012, 17:06:59 schrieb Alan Stern:
> On Wed, 6 Jun 2012, Ming Lei wrote:

> > So many purposes, you need to split your patches for review easily, :-)
>
> Not just that... usb-skeleton is intended to be a good example, to
> help people learn how to write USB drivers. It's already far too
> complicated for this purpose, and adding more complication will just
> make it worse.
>
> Instead of adding things to usb-skeleton, we should take things away.

Not really. The features in the driver make sense. Probably we should
have two versions. One simple and basic and the other showing advanced
techniques. And a lot more comments.

Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/