Re: [PATCH 02/11] code cleanup

[Oliver Neukum]

Am Mittwoch, 6. Juni 2012, 18:27:03 schrieb stefani@xxxxxxxxxxx:
> From: Stefani Seibold <stefani@xxxxxxxxxxx>
> 
> - consistent nameing
> - more compact style
> - remove unneeded code
> 

>  static int skel_flush(struct file *file, fl_owner_t id)
>  {
> -	struct usb_skel *dev;
> +	struct usb_skel *dev = file->private_data;
>  	int res;
>  
> -	dev = file->private_data;
> -	if (dev == NULL)
> -		return -ENODEV;
> -

flush() is intended to report errors. A check for disconnect is needed.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/