RE: [E1000-devel] [next-net PATCH]drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX nameoutput by e1000e

[Allan, Bruce W]

> -----Original Message-----
> From: Jeff Kirsher [mailto:jeffrey.t.kirsher@xxxxxxxxx]
> Sent: Wednesday, June 06, 2012 5:41 PM
> To: Ethan Zhao
> Cc: e1000-devel@xxxxxxxxxxxxxxxxxxxxx; Linux NICS; LKML
> Subject: Re: [E1000-devel] [next-net PATCH]
> drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX
> name output by e1000e
> 
> On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote:
> > commit ca3ccc6835943287b6f69e973c126a02bc4de409
> > Author: ethan.zhao <ethan.kernel@xxxxxxxxx>
> > Date:   Wed Jun 6 07:32:11 2012 -0700
> >
> >         modified:   drivers/net/ethernet/intel/e1000e/param.c
> >
> >     While e1000e_check_options() is called, netdev is not
> registered,
> > so the
> >     e1000e driver will print out confused ethernet interface name
> > (unregistered net_device) :
> >
> >     e1000e 0000:04:00.0:(unregistered net_device): Interrupt
> > Throttling Rate (ints/sec) set to dynamic conservative mode
> >
> >     So change e_info() back to dev_printk() by simply redefine the
> > e_info macro used by
> >     e1000e_check_options() and e1000_validate_option
> >
> >     after applied this patch, we got:
> >
> >     e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set to
> > dynamic conservative mode
> >     e1000e 0000:04:00.0: irq 95 for MSI/MSI-X
> 
> NACK, I currently have a patch in my queue from Bruce Allan to resolve
> this issue.  I should be pushing the patch upstream in a few days.

For clarification, the problem with the NACK'ed patch is it is missing a
number of instances of the same issue that is meant to be addressed by the
patch.

¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_