Re: [PATCH] PCI: Add Ralink RT2800 broken INTx masking quirk

From: Alex Williamson
Date: Thu Jun 07 2012 - 13:43:26 EST


On Thu, 2012-06-07 at 19:18 +0200, Jan Kiszka wrote:
> On 2012-06-07 19:05, Alex Williamson wrote:
> > On Thu, 2012-06-07 at 08:18 +0200, Andreas Hartmann wrote:
> >> Hello Alex,
> >>
> >> what about a module parameter to achieve this behaviour manually by
> >> the user without recompiling? I fear, there are much more candidates
> >> out there needing this "feature".
> >
> > Yeah, that's probably a good idea. For debugging and letting users have
> > a workaround rather than any kind of regular use. I'll add a nointxmask
> > to vfio-pci with a description indicating that if it fixes a device to
> > report it for quirking. Thanks,
>
> Isn't this controllable on a per-device base from userspace (or is this
> what you mean)? That would nicely align to qemu-kvm's pci-assign
> share_intx property (and may allow to map pci-assign's user-visible
> interface to a vfio backend one day).

No, there's currently no per-device control of this from userspace with
VFIO. It wouldn't be hard to make use of flags bits in the ioctls to
support it, but I don't just want to move the blacklist from the kernel
out to the user. Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/