Re: [PATCH 1/7] drivers/ide/ide-cs.c: adjust suspicious bitoperation
From: David Miller
Date: Thu Jun 07 2012 - 17:46:14 EST
From: Julia Lawall <Julia.Lawall@xxxxxxx>
Date: Wed, 6 Jun 2012 23:41:35 +0200
> - if (!(pdev->resource[0]->flags & IO_DATA_PATH_WIDTH_8)) {
> + if ((p1dev->resource[0]->flags & IO_DATA_PATH_WIDTH)
I'm really surprised someone as thorough as yourself did not
compile test this.
This is just more proof that it's absolutely pointless to make any
changes at all to the old IDE layer. Nobody really cares, and the
risk %99.999 of the time is purely to introduce regressions rather
than make forward progress.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/