Re: [PATCH 6/7] pstore/ram: Make ECC size configurable

[Dan Carpenter]

On Mon, Jun 18, 2012 at 07:15:55PM -0700, Anton Vorontsov wrote:
> @@ -478,7 +478,7 @@ static void ramoops_register_dummy(void)
>  	dummy_data->record_size = record_size;
>  	dummy_data->console_size = ramoops_console_size;
>  	dummy_data->dump_oops = dump_oops;
> -	dummy_data->ecc = ramoops_ecc;
> +	dummy_data->ecc_size = ramoops_ecc == 1 ? 16 : ramoops_ecc;
>  

I know it's in the change log, but there should probably be a
comment here as well that 1 and 16 are magic backwards compatability
numbers.

>  	dummy = platform_device_register_data(NULL, "ramoops", -1,
>  			dummy_data, sizeof(struct ramoops_platform_data));

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/