RE: [PATCH 1/1 v4] leds: Add LED driver for lm3556 chip

[Kim, Milo]

> LM3556 :
> The LM3556 is a 4 MHz fixed-frequency synchronous boost
> converter plus 1.5A constant current driver for a high-current white
> LED.

Overall, it looks pretty good to me, especially core functionality of lm3556 is well supported and it's easy to use.

Just one thing to be better,
I would suggest to use module_i2c_driver() rather than lm3556_init/lm3556_exit for code simplicity.

> +static int __init lm3556_init(void)
> +{
> +	return i2c_add_driver(&lm3556_i2c_driver);
> +}
> +
> +static void __exit lm3556_exit(void)
> +{
> +	i2c_del_driver(&lm3556_i2c_driver);
> +}
> +
> +module_init(lm3556_init);
> +module_exit(lm3556_exit);

module_i2c_driver(lm3556_i2c_driver);

Thanks,
Milo -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/