RE: [PATCH] cpuidle: move field disable from per-driver to per-cpu

[Zhang, Yanmin]

Andrew,

You are right. It's just to reuse current functions, which show 64bit usage/time. Should we add 2 new macros to define new functions for int?

Yanmin

-----Original Message-----
From: Andrew Morton [mailto:akpm@xxxxxxxxxxxxxxxxxxxx] 
Sent: Saturday, June 23, 2012 7:10 AM
To: Liu, ShuoX
Cc: linux-kernel@xxxxxxxxxxxxxxx; Brown, Len; Zhang, Yanmin; Andrew J. Schorr; Deepthi Dharwar
Subject: Re: [PATCH] cpuidle: move field disable from per-driver to per-cpu

On Thu, 14 Jun 2012 10:52:48 +0800
ShuoX Liu <shuox.liu@xxxxxxxxx> wrote:

> From: ShuoX Liu <shuox.liu@xxxxxxxxx>
> 
> Andrew J.Schorr raises a question. When he changes the disable setting 
> on a single CPU, it affects all the other CPUs. Basically, currently, 
> the disable field is per-driver instead of per-cpu. All the C states 
> of the same driver are shared by all CPU in the same machine.
> 
> Below patch changes field disable to per-cpu, so we could set this 
> separately for each cpu.
> 
> ...
>
> --- a/include/linux/cpuidle.h
> +++ b/include/linux/cpuidle.h
> @@ -34,6 +34,7 @@ struct cpuidle_driver;  struct cpuidle_state_usage {
>  	void		*driver_data;
>  
> +	unsigned long long	disable;

hrmpf.  We're using 64 bits for this where one bit would do, afaict because the magic macros in drivers/cpuidle/sysfs.c are using %llu.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/