Re: [PATCH 01/22 v4] Input: atmel_mxt_ts - set phys to i2c clientadapter name

From: Daniel Kurtz
Date: Mon Jun 25 2012 - 05:59:05 EST


On Mon, Jun 25, 2012 at 4:15 PM, Henrik Rydberg <rydberg@xxxxxxxxxxx> wrote:
>
> On Thu, Jun 21, 2012 at 01:41:07AM -0700, Dmitry Torokhov wrote:
> > On Mon, Jun 18, 2012 at 12:08:21PM +0800, Daniel Kurtz wrote:
> > > This allows userspace to more easily distinguish which bus a
> > > particular
> > > atmel_mxt_ts device is attached to.
> > >
> > > Signed-off-by: Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
> > > ---
> > >  drivers/input/touchscreen/atmel_mxt_ts.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c
> > > b/drivers/input/touchscreen/atmel_mxt_ts.c
> > > index 42e6450..eda9eed 100644
> > > --- a/drivers/input/touchscreen/atmel_mxt_ts.c
> > > +++ b/drivers/input/touchscreen/atmel_mxt_ts.c
> > > @@ -1106,6 +1106,7 @@ static int __devinit mxt_probe(struct i2c_client
> > > *client,
> > >     }
> > >
> > >     input_dev->name = "Atmel maXTouch Touchscreen";
> > > +   input_dev->phys = client->adapter->name;
> >
> > Normally we set phys to 'xxx/input0' nstead of just the adaptor name.
>
> Daniel, will we be seeing another version of this patch?

Yes. Any guidance on "xxx" ? atmel_mxt_ts?
What if there are two devices using the same driver?

>
> Thanks,
> Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/