Re: [PATCH 7/8] auto bind the memory device which is hotpluged beforethe driver is loaded

From: David Rientjes
Date: Wed Jun 27 2012 - 00:33:22 EST


On Tue, 26 Jun 2012, Konrad Rzeszutek Wilk wrote:

> > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> > index 148c88a..a682657 100644
> > --- a/drivers/acpi/acpi_memhotplug.c
> > +++ b/drivers/acpi/acpi_memhotplug.c
> > @@ -52,6 +52,9 @@ MODULE_LICENSE("GPL");
> > #define MEMORY_POWER_ON_STATE 1
> > #define MEMORY_POWER_OFF_STATE 2
> >
> > +static bool auto_probe;
> > +module_param(auto_probe, bool, S_IRUGO | S_IWUSR);
> > +
> > static int acpi_memory_device_add(struct acpi_device *device);
> > static int acpi_memory_device_remove(struct acpi_device *device, int type);
> >
> > @@ -515,12 +518,44 @@ acpi_memory_register_notify_handler(acpi_handle handle,
> > u32 level, void *ctxt, void **retv)
> > {
> > acpi_status status;
> > -
> > + struct acpi_memory_device *mem_device = NULL;
> > + unsigned long long current_status;
>
> Can it just be unsigned long?
>

Not on 32-bit, the ACPI 2.0 and later specs can handle 64 bit integers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/