Re: [PATCH v2] memcg: unify mem_control_xxx to memcg_xxx

[Glauber Costa]

On 06/27/2012 12:59 PM, Michal Hocko wrote:
> On Wed 27-06-12 12:43:50, Glauber Costa wrote:
> > On 06/27/2012 04:16 AM, Wanpeng Li wrote:
> > > From: Wanpeng Li <liwp@xxxxxxxxxxxxxxxxxx>
> > >
> > > Changelog:
> > >
> > > V2 -> V1:
> > >
> > > * replace memory_cgroup_xxx by memcg_xxx
> > >
> > > Unify memcg functions to memcg_xxx.
> >
> >
> > This patch achieves nothing.
> > You're changing a couple of function names. Andrew stated goal was
> > to change *all* function names from mem_cgroup_xxx to memcg_xxx, not
> > just one or two.
>
> No mass things now, please.
> git grep mem_cgroup_ mm/ include/ | wc -l
> 863
>
> This will be real pain for merging.
It's either that, or I have my new functions named memcg_ and we live 
with the inconsistency.

Point is, changing one function name as he did, achieves nothing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/