Re: [PATCH 36/36] staging: comedi: cb_pcidas: cleanup dac08_write()

[Ian Abbott]

On 2012-06-27 02:12, H Hartley Sweeten wrote:
> Reverse the logic of the test against the cached value so that
> the function only has one exit point.
>
> Make the logic of the dac write a bit clearer by create a local
> variable for the address used in the outw() calls and masking the
> value to write and setting the enable bits before doing the outw()
> calls. Add a comment just to make sure it's clear.
>
> Also, add a comment about the 'return 1;'.  This should be
> insn->n which is the number of data parameters used to do the
> dac08_write_insn() but the insn is not a parameter to this
> function.

It's probably better to make dac08_write() return void and return 1 in 
dac08_write_insn().

Actually, I think dac08_write_insn() ought to call dac08_write() in a 
loop, iterating over data[] and return insn->n.  That's what the 
INSN_WRITE instruction is meant to do although it's not implemented all 
that consistently by the drivers.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/