Re: [PATCH 4/7] tracing/function: Introduce persistent trace option

[Steven Rostedt]

On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:
>  
> @@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int set)
>  
>  		return 0;
>  	}
> +	if (bit == TRACE_FUNC_OPT_PSTORE)
> +		return 0;

Perhaps this should be a switch() statement, or at least put a
 } else if () {

As it can't be bit == TRACE_FUNC_OPT_STACK and bit ==
TRACE_FUNC_OPT_PSTORE.

-- Steve

>  
>  	return -EINVAL;
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/