Re: [PATCH] asm-generic: fix compile breakage "'TAINT_WARN'undeclared"

From: Paul Mundt
Date: Wed Jun 27 2012 - 10:22:35 EST


On Wed, Jun 27, 2012 at 03:52:27PM +0200, Guennadi Liakhovetski wrote:
> TAINT_WARN is defined in kernel.h and used in asm-generic/bug.h. Not
> including kernel.h there breaks build on sh:
>
> In file included from linux/include/linux/thread_info.h:54,
> from linux/include/linux/preempt.h:9,
> from linux/include/linux/spinlock.h:50,
> from linux/include/linux/mmzone.h:7,
> from linux/include/linux/gfp.h:4,
> from linux/include/linux/mm.h:8,
> from linux/arch/sh/kernel/asm-offsets.c:13:
> linux/arch/sh/include/asm/thread_info.h: In function 'set_restore_sigmask':
> linux/arch/sh/include/asm/thread_info.h:172: error: 'TAINT_WARN' undeclared (first use in this function)
> linux/arch/sh/include/asm/thread_info.h:172: error: (Each undeclared identifier is reported only once
> linux/arch/sh/include/asm/thread_info.h:172: error: for each function it appears in.)
>
> Also, since nothing in bug.h is usable from assembly, it is safe to extend
> the "#ifndef __ASSEMBLY__" block over all WARN() macros.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

Already fixed in mainline.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/