Re: [PATCH 03/23] perf: Add ability to attach user level registersdump to sample

[Frederic Weisbecker]

On Tue, Jun 19, 2012 at 05:47:54PM +0200, Jiri Olsa wrote:
> @@ -4061,6 +4105,19 @@ void perf_prepare_sample(struct perf_event_header *header,
>  		}
>  		header->size += size;
>  	}
> +
> +	if (sample_type & PERF_SAMPLE_REGS_USER) {
> +		/* regs dump available bool */
> +		int size = sizeof(u64);
> +
> +		data->regs_user = perf_sample_regs_user(regs);
> +		if (data->regs_user) {
> +			u64 mask = event->attr.sample_regs_user;
> +			size += hweight64(mask) * sizeof(u64);
> +		}
> +
> +		header->size += size;

We'll need to remove the 64 bits registers for compat tasks but other than
that, it looks ok.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/