Re: [PATCH] ASoC: snd_dmaengine: add common api for pcm_mmap

From: Laxman Dewangan
Date: Thu Jun 28 2012 - 07:59:32 EST


On Thursday 28 June 2012 04:21 PM, Mark Brown wrote:
* PGP Signed by an unknown key

On Thu, Jun 28, 2012 at 12:31:26PM +0530, Laxman Dewangan wrote:
The pcm mmap for the substream dma buffer is done using the
dma_mmap_writecombine().
Some of the chip sound driver like Spear, Tegra, Davinci,
ep93xx,snd_imx, snd_mxs, NUC900, OMAP, Samsung are doing this
mapping locally.
Add api in the snd dmaengine driver so that different client of
snd dmaengine can use this rather than implementing locally.
OK, but I'd expect this to come along with one or more patches
converting at least some of the users to the new API...

This is effort towards moving the Tegra pcm driver for dmangine based dma driver inplace of legacy dma driver for Tegra which have private API.

Currently, following 4 pcm driver can use this API directly keeping that they already using the generic snd dmaengine pcm driver.
ep93xx,
spear,
fsl,
mxs.
And Tegra will be next.

Other driver which can use this API are davinci, OMAP, samsung but because they are not using the snd_dmaengine_pcm driver's api as of now so not be very much useful for them.


Should I send one patch per driver change or squash all 4 file changes in one patch? Whatever will be easy or recommended?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/