Re: [PATCH v2 3/6] kvm: Sanitize KVM_IRQFD flags

From: Avi Kivity
Date: Thu Jun 28 2012 - 08:35:59 EST


On 06/27/2012 12:21 PM, Michael S. Tsirkin wrote:
> On Tue, Jun 26, 2012 at 11:09:32PM -0600, Alex Williamson wrote:
>> We only know of one so far.
>>
>> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
>
> Ugh. So we have a bug: we should have sanitized the fields.
> If there's buggy userspace that only set the low bit
> it will break with this change.
> Is it too late now? Do we need KVM_IRQFD2 which
> sanitized fields properly? Avi?

We try and see. Commit this, if somebody complain, revert after
apologizing profusely. If no one notices, we can claim those bits.



--
error compiling committee.c: too many arguments to function


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/