Re: [PATCH 0/4] Was: deferring __fput()

From: Oleg Nesterov
Date: Thu Jun 28 2012 - 12:25:08 EST


On 06/28, Al Viro wrote:
>
> The list removal logics in mine looks really ugly ;-/

Basically the code is almost the same as mine.

But task_work_add() can be simplified a bit, no need to check
last != NULL twice.

last = task->task_works ?: twork;
task->last_twork = twork;
twork->next = last->next; /* XXX */
last->next = twork;

If ->task_works == NULL, then XXX is meaningless but safe.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/