Re: [PATCH] backlight: add support for disabling backlights viasysfs

From: Matthew Garrett
Date: Thu Jun 28 2012 - 15:10:41 EST


On Thu, Jun 28, 2012 at 02:07:06PM -0500, Seth Forshee wrote:

> Rather than trying to address this situation in a piecemeal fashion, we
> should find a solution that deal with disabling broken backlights more
> generically. This patch does so by adding an "enabled" attribute to
> sysfs for backlight devices. Writing 0 to this attribute disables the
> backlight, blocking most attempts to change the state. Tools like udev
> can set use this attribute to disable known broken backlight interfaces,
> and tools like gnome-settings-daemon can query the attribute to avoid
> using disabled backlights.

I'm not entirely thrilled by this, especially because in several cases I
suspect that we're just going to end up disabling acpi_backlight rather
than fixing any of the range of integration bugs we still have with it.
If anyone has links with OEMs then I'd love to know how Windows handles
backlight control policy, but otherwise I think Corentin's approach of
having the vendor drivers promote or demote themselves makes more sense
than pushing the problem out to userspace.

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/