Re: [PATCH] mm: CONFIG_HAVE_MEMBLOCK_NODE ->CONFIG_HAVE_MEMBLOCK_NODE_MAP

[Tejun Heo]

On Sat, Jun 30, 2012 at 01:44:37AM +0530, Rabin Vincent wrote:
> 0ee332c14518699 ("memblock: Kill early_node_map[]") wanted to replace
> CONFIG_ARCH_POPULATES_NODE_MAP with CONFIG_HAVE_MEMBLOCK_NODE_MAP but
> ended up replacing one occurence with a reference to the non-existent
> symbol CONFIG_HAVE_MEMBLOCK_NODE.
> 
> Signed-off-by: Rabin Vincent <rabin@xxxxxx>

Please add Cc: stable@xxxxxxxxxxxxxxxx

 Acked-by: Tejun Heo <tj@xxxxxxxxxx>

> ---
>  include/linux/mmzone.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 2427706..1d0a9a3 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -773,7 +773,7 @@ extern int movable_zone;
>  
>  static inline int zone_movable_is_highmem(void)
>  {
> -#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE)
> +#if defined(CONFIG_HIGHMEM) && defined(CONFIG_HAVE_MEMBLOCK_NODE_MAP)
>  	return movable_zone == ZONE_HIGHMEM;

This probably has been doing something weird to 32bit machines w/
memory hotplug configured (which probably are extremely rare).  It
would be nice if the patch description explained what behavior it
actually fixes.  How did you find this?  From config check util or did
you actually see something broken?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/